On 2021/7/13 17:32, Michal Hocko wrote: > On Mon 12-07-21 19:16:47, Miaohe Lin wrote: >> On 2021/7/12 15:28, Michal Hocko wrote: >>> On Sat 10-07-21 18:03:29, Miaohe Lin wrote: >>>> We couldn't know whether the page is being freed elsewhere until we failed >>>> to increase the page count. >>> >>> This is moving a hard to understand comment from one place to another. >> >> If get_page_unless_zero failed, the page could have been freed elsewhere. I think >> this looks straightforward but doesn't help a lot. Are you preferring to just >> remove this comment ? > > Yes the comment in its current form is not really helpful much. Does it > deserve a single liner to drop it? Likely not on its own without more > changes in that area. Sure, I will drop this single patch. And I would send a new patch when I collect enough misleading/obsolete comments to fix. Thanks. >
