On Tue, Nov 15, 2011 at 10:49 PM, Tejun Heo <tj@xxxxxxxxxx> wrote: > On Tue, Nov 15, 2011 at 04:36:46PM +0800, Dave Young wrote: >> per_cpu_ptr_to_phys iterate all cpu to get the phy addr >> let's leave the caller to pass the cpu number to it. >> >> Actually in the only one user show_crash_notes, >> cpunum is provided already before calling this. >> >> Signed-off-by: Dave Young <dyoung@xxxxxxxxxx> > > Does this matter? If it's not a performance critical path, I'd rather > keep the generic funtionality. Hi, why not? the code is redundant, it's an improvement of the code, isn't it? Also, kernel code size will be smaller. > > Thanks. > > -- > tejun > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> > -- Regards Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href