Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock()
From: Johannes Weiner <hannes@xxxxxxxxxxx>
Date: Wed, 7 Jul 2021 13:08:51 -0400
Cc: linux-mm@xxxxxxxxx, cgroups@xxxxxxxxxxxxxxx, Michal Hocko <mhocko@xxxxxxxxxx>, Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
In-reply-to: <20210630040034.1155892-14-willy@infradead.org>
References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-14-willy@infradead.org>

On Wed, Jun 30, 2021 at 05:00:29AM +0100, Matthew Wilcox (Oracle) wrote:
> -static void __unlock_page_memcg(struct mem_cgroup *memcg)
> +static void __memcg_unlock(struct mem_cgroup *memcg)

This is too generic a name. There are several locks in the memcg, and
this one only locks the page->memcg bindings in the group.

Follow-Ups:
- Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock()
  - From: Matthew Wilcox

References:
- [PATCH v3 00/18] Folio conversion of memcg
  - From: Matthew Wilcox (Oracle)
- [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock()
  - From: Matthew Wilcox (Oracle)

Prev by Date: [PATCH] mm: try_to_unmap() is now void
Next by Date: Re: [PATCH] mm: try_to_unmap() is now void
Previous by thread: Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock()
Next by thread: Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux