On Tue, Nov 15, 2011 at 03:04:18PM +0800, Shaohua Li wrote: > We have tlb_remove_tlb_entry to indicate a pte tlb flush entry should be > flushed, but not a corresponding API for pmd entry. This isn't a problem so far > because THP is only for x86 currently and tlb_flush() under x86 will flush > entire TLB. But this is confusion and could be missed if thp is ported to > other arch. > Also converted tlb->need_flush = 1 to a VM_BUG_ON(!tlb->need_flush) in > __tlb_remove_page() as suggested by Andrea Arcangeli. __tlb_remove_page() > is supposed to be called after tlb_remove_xxx_tlb_entry() and we can catch > any misuse. > > Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx> Reviewed-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>