> >
> > +void __weak abort_xol(struct pt_regs *regs, struct uprobe_task *utask)
> > +{
> > + set_instruction_pointer(regs, utask->vaddr);
> > +}
>
> OK, this is fine on 32bit. But X86_64 should also handle
> UPROBES_FIX_RIP_AX/CX?
>
> IOW, shouldn't we also do
>
> if (uprobe->fixups & UPROBES_FIX_RIP_AX)
> regs->ax = tskinfo->saved_scratch_register;
> else if (uprobe->fixups & UPROBES_FIX_RIP_CX)
> regs->cx = tskinfo->saved_scratch_register;
>
> on 64bit?
Yes, we should be doing this on x86_64. Since abort_xol is a weak
function, I will have x86_64 specific abort_xol.
--
Thanks and Regards
Srikar
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>