On Wed, Jun 30, 2021 at 05:00:31AM +0100, Matthew Wilcox (Oracle) wrote: > This is the folio equivalent of mem_cgroup_page_lruvec(). I'm just going through and removing the wrappers. Why is this function called this? There's an odd mix of lock_page_memcg() page_memcg() count_memcg_page_event() split_page_memcg() vs mem_cgroup_charge() mem_cgroup_swapin_charge_page() mem_cgroup_lruvec() mem_cgroup_from_task() I'd really like to call this function folio_lruvec(). It happens to behave differently if the folio is part of a memcg, but conceptually, lruvecs aren't particularly tied to memcgs. ... are there any other functions you'd like to rename while I'm changing pages to folios?