On Fri, Jun 18, 2021 at 02:59:43PM +0300, Dan Carpenter wrote: > On Fri, Jun 18, 2021 at 11:14:41AM +0100, Mel Gorman wrote: > > On Fri, Jun 18, 2021 at 12:03:45PM +0300, Dan Carpenter wrote: > > > Hello Mel Gorman, > > > > > > The patch 0f87d9d30f21: "mm/page_alloc: add an array-based interface > > > to the bulk page allocator" from Apr 29, 2021, leads to the following > > > static checker warning: > > > > > > mm/page_alloc.c:5338 __alloc_pages_bulk() > > > warn: potentially one past the end of array 'page_array[nr_populated]' > > > > > > > Thanks Dan. > > > > Does this work for you? > > > > It works for me. It doesn't silence the Smatch warning because Smatch > thinks that all the callers pass a non-NULL "page_array" and gets > confused by the "if (page_array)" checks. :/ > Well..... it's technically correct because the list interface is currently unused. The thinking is to leave it for now and delete the list interface if it remains unused after a while. -- Mel Gorman SUSE Labs
