On Fri, Jun 18, 2021 at 12:59 PM gumingtao <gumingtao1225@xxxxxxxxx> wrote:
>
> It is better to replace the function name with %s.
>
> Signed-off-by: gumingtao <gumingtao@xxxxxxxxxx>
> ---
> mm/slab_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index a4a5714..36127dc 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name,
> panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
I am just wondering:
Can you also make that refactoring change for the panic() call as well?
How about checking the whole file for such patterns and doing that
change for all occurrences?
> name, err);
> else {
> - pr_warn("kmem_cache_create(%s) failed with error %d\n",
> - name, err);
> + pr_warn("%s(%s) failed with error %d\n",
> + __func__, name, err);
> dump_stack();
> }
> return NULL;
> --
> 2.7.4
>
