Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 16 Jun 2021 11:27:02 +0100
Cc: dhowells@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Vlastimil Babka <vbabka@xxxxxxx>, William Kucharski <william.kucharski@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <20210614201435.1379188-25-willy@infradead.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <20210614201435.1379188-25-willy@infradead.org> <20210614201435.1379188-1-willy@infradead.org>

Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> +	    !folio_unevictable(folio) && folio_lru(folio)) {

Hmmm...  Would folio_lru() be better named folio_on_lru()?  folio_lru() sounds
like it returns the folio's LRU.

David

Follow-Ups:
- Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()
  - From: Matthew Wilcox

References:
- [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()
  - From: Matthew Wilcox (Oracle)
- [PATCH v11 00/33] Memory folios
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH v11 22/33] mm/filemap: Add folio_wait_locked()
Next by Date: Re: [PATCH 03/11] mm: page_vma_mapped_walk(): use pmd_read_atomic()
Previous by thread: Re: [PATCH v11 22/33] mm/filemap: Add folio_wait_locked()
Next by thread: Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]