Re: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 15 Jun 2021 18:37:42 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20210615162342.1669332-4-willy@infradead.org>
References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-4-willy@infradead.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jun 15, 2021 at 05:23:39PM +0100, Matthew Wilcox (Oracle) wrote:
> The only difference between iomap_set_page_dirty() and
> __set_page_dirty_nobuffers() is that the latter includes a debugging
> check that a !Uptodate page has private data.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 0/6] Further set_page_dirty cleanups
  - From: Matthew Wilcox (Oracle)
- [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH 2/6] mm/writeback: Use __set_page_dirty in __set_page_dirty_nobuffers
Next by Date: Re: [PATCH 4/6] fs: Remove anon_set_page_dirty()
Previous by thread: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers
Next by thread: Re: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux