Re: [PATCH v29 07/13] mm/damon: Implement a debugfs-based user space interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Returns non-empty string on success, negarive error code otherwise.

Nit: typo, 'negarive'


+    if (ctx->kdamond) {
+        if (targetid_is_pid(ctx))
+            dbgfs_put_pids(targets, nr_targets);
+        ret = -EBUSY;
+        goto unlock_out;

I don't understand this block, what does EBUSY mean in this context?

+    if (sscanf(kbuf, "%s", kbuf) != 1) {
+        kfree(kbuf);
+        return -EINVAL;
+    }

Nit, this diverts from other patterns use elsewhere where error conditions that need to free memory use a goto label.






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux