Hi Andy, On 6/8/2021 11:43 PM, Faiyaz Mohammed wrote: > > > On 6/8/2021 11:05 PM, Vlastimil Babka wrote: >> On 6/8/21 7:11 PM, Faiyaz Mohammed wrote: >>> >>> >>> On 6/8/2021 5:20 PM, Andy Shevchenko wrote: >>>> On Tue, Jun 8, 2021 at 11:45 AM Faiyaz Mohammed <faiyazm@xxxxxxxxxxxxxx> wrote: >>>>> >>>>> alloc_calls and free_calls implementation in sysfs have two issues, >>>>> one is PAGE_SIZE limitation of sysfs and other is it does not adhere >>>>> to "one value per file" rule. >>>>> >>>>> To overcome this issues, move the alloc_calls and free_calls >>>>> implementation to debugfs. >>>>> >>>>> Debugfs cache will be created if SLAB_STORE_USER flag is set. >>>>> >>>>> Rename the alloc_calls/free_calls to alloc_traces/free_traces, >>>>> to be inline with what it does. >>>>> >>>>> Signed-off-by: Faiyaz Mohammed <faiyazm@xxxxxxxxxxxxxx> >>>>> --- >>>> >>>> It seems you missed the version bump along with changelog. >>>> Note, some maintainers (actually quite many I think) are using tools >>>> to fetch up the patches and two patches with the same version is a >>>> problem. Hence I do not consider it a nit-pick. >>>> >>> Hmmm, I think to avoid same version problem I have to push same patch >>> with new version number and thank you for your patience. >> >> I *think* Andrew wouldn't have this issue, so maybe resend only if he says it's >> needed. > Sure, I will send if he ask. Do I need to send patch with new version number?. >> On the other hand I did have troubles to apply the last version locally, patch >> (tool) complained of patch (file) being malformed at the end. Did you add or >> delete lines from it after generating the patch? I had to use the recountdiff > Yes, I added one line manually, I think that causes the issue. > >> tool to fix this. If you're going to resend, please make sure it's without the >> same issue. >> > Okay > >>> Thanks and regards, >>> Mohammed Faiyaz >>> >>
