Re: [PATCH net-next v8 3/5] page_pool: Allow drivers to hint on SKB recycling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matteo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Matteo-Croce/page_pool-recycle-buffers/20210608-030512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1a42624aecba438f1d114430a14b640cdfa51c87
config: x86_64-randconfig-b001-20210607 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ae973380c5f6be77ce395022be40350942260be9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # apt-get install iwyu # include-what-you-use
        # https://github.com/0day-ci/linux/commit/95da7ab53bd3ac29bee6be7c89fda1f7c506a182
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matteo-Croce/page_pool-recycle-buffers/20210608-030512
        git checkout 95da7ab53bd3ac29bee6be7c89fda1f7c506a182
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross C=1 CHECK=iwyu ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


iwyu warnings: (new ones prefixed by >>)
   net/core/skbuff.c:77:1: iwyu: warning: superfluous #include <linux/highmem.h>
   net/core/skbuff.c:43:1: iwyu: warning: superfluous #include <linux/inet.h>
   net/core/skbuff.c:41:1: iwyu: warning: superfluous #include <linux/interrupt.h>
   net/core/skbuff.c:37:1: iwyu: warning: superfluous #include <linux/module.h>
   net/core/skbuff.c:60:1: iwyu: warning: superfluous #include <linux/prefetch.h>
   net/core/skbuff.c:56:1: iwyu: warning: superfluous #include <linux/rtnetlink.h>
   net/core/skbuff.c:52:1: iwyu: warning: superfluous #include <linux/string.h>
   net/core/skbuff.c:75:1: iwyu: warning: superfluous #include <linux/uaccess.h>
   net/core/skbuff.c:69:1: iwyu: warning: superfluous #include <net/ip6_checksum.h>
>> net/core/skbuff.c:73:1: iwyu: warning: superfluous #include <net/page_pool.h>
   net/core/skbuff.c:65:1: iwyu: warning: superfluous #include <net/protocol.h>

vim +73 net/core/skbuff.c

^1da177e4c3f41 Linus Torvalds   2005-04-16  64  
^1da177e4c3f41 Linus Torvalds   2005-04-16  65  #include <net/protocol.h>
^1da177e4c3f41 Linus Torvalds   2005-04-16  66  #include <net/dst.h>
^1da177e4c3f41 Linus Torvalds   2005-04-16  67  #include <net/sock.h>
^1da177e4c3f41 Linus Torvalds   2005-04-16  68  #include <net/checksum.h>
ed1f50c3a7c1ad Paul Durrant     2014-01-09  69  #include <net/ip6_checksum.h>
^1da177e4c3f41 Linus Torvalds   2005-04-16  70  #include <net/xfrm.h>
8822e270d69701 John Hurley      2019-07-07  71  #include <net/mpls.h>
3ee17bc78e0f3f Mat Martineau    2020-01-09  72  #include <net/mptcp.h>
95da7ab53bd3ac Ilias Apalodimas 2021-06-07 @73  #include <net/page_pool.h>
^1da177e4c3f41 Linus Torvalds   2005-04-16  74  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- kbuild@xxxxxxxxxxxx
To unsubscribe send an email to kbuild-leave@xxxxxxxxxxxx

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux