Re: [PATCH] oom: do not kill tasks with oom_score_adj OOM_SCORE_ADJ_MIN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(11/7/2011 1:54 PM), David Rientjes wrote:
> On Fri, 4 Nov 2011, Michal Hocko wrote:
> 
>> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> index e916168..4883514 100644
>> --- a/mm/oom_kill.c
>> +++ b/mm/oom_kill.c
>> @@ -185,6 +185,9 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
>>  	if (!p)
>>  		return 0;
>>  
>> +	if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>> +		return 0;
>> +
>>  	/*
>>  	 * The memory controller may have a limit of 0 bytes, so avoid a divide
>>  	 * by zero, if necessary.
> 
> This leaves p locked, you need to do task_unlock(p) first.
> 
> Once that's fixed, please add my
> 
> 	Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Agreed.
	Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]