On Fri, 4 Jun 2021, Kirill A. Shutemov wrote: > > I think adding support for THP in try_to_unmap_one() is the most > future-proof way. We would need it there eventually. Yes, I'd love to delete unmap_mapping_page() and use try_to_unmap(), but couldn't easily do it. I did cut out one paragraph which said: "Next iteration, I would probably refactor zap_huge_pmd() so that the same code could be used from zap_pmd_range() or try_to_unmap_one(); but that seems riskier and more trouble than this current iteration." And I've certainly not found time to go back and try that since. > > But this works too: > > Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> Thanks, Hugh