On Wed, Jun 02, 2021 at 04:52:27PM -0700, Peter Collingbourne wrote: > In an upcoming change we would like to add a flag to > GFP_HIGHUSER_MOVABLE so that it would no longer be an OR > of GFP_HIGHUSER and __GFP_MOVABLE. This poses a problem for > alloc_zeroed_user_highpage_movable() which passes __GFP_MOVABLE > into an arch-specific __alloc_zeroed_user_highpage() hook which ORs > in GFP_HIGHUSER. > > Since __alloc_zeroed_user_highpage() is only ever called from > alloc_zeroed_user_highpage_movable(), we can remove one level > of indirection here. Remove __alloc_zeroed_user_highpage(), > make alloc_zeroed_user_highpage_movable() the hook, and use > GFP_HIGHUSER_MOVABLE in the hook implementations so that they will > pick up the new flag that we are going to add. > > Signed-off-by: Peter Collingbourne <pcc@xxxxxxxxxx> > Link: https://linux-review.googlesource.com/id/Ic6361c657b2cdcd896adbe0cf7cb5a7fbb1ed7bf Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>