On 02.06.21 10:47, Max Gurtovoy wrote:
The "if" clause can fit to one line. Also while we're here, fix the end
pfn print (use %#lx instead of #%lx).
I think the subject could be more expressive. I'd suggest
"mm,memory_hotplug: cleanup alignment checks in check_pfn_span"
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
Signed-off-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
---
mm/memory_hotplug.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 70620d0dd923..8c3b423c1141 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -288,10 +288,9 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages,
min_align = PAGES_PER_SUBSECTION;
else
min_align = PAGES_PER_SECTION;
- if (!IS_ALIGNED(pfn, min_align)
- || !IS_ALIGNED(nr_pages, min_align)) {
- WARN(1, "Misaligned __%s_pages start: %#lx end: #%lx\n",
- reason, pfn, pfn + nr_pages - 1);
+ if (!IS_ALIGNED(pfn, min_align) || !IS_ALIGNED(nr_pages, min_align)) {
+ WARN(1, "Misaligned __%s_pages start: %#lx end: %#lx\n",
+ reason, pfn, pfn + nr_pages - 1);
return -EINVAL;
}
return 0;
--
Thanks,
David / dhildenb
