On Wed 2021-05-26 15:27:37, Stephen Boyd wrote: > Quoting Petr Mladek (2021-05-26 06:47:23) > > On Wed 2021-05-26 12:48:47, Vlastimil Babka wrote: > > > On 5/26/21 4:56 AM, Stephen Boyd wrote: > > > > Obscuring the pointers that slub shows when debugging makes for some > > > > confusing slub debug messages: > > > > > > > > Padding overwritten. 0x0000000079f0674a-0x000000000d4dce17 > > > > > > > > I opted for extern because I guess we don't want to advertise > > > > no_hash_pointers_enable() in some sort of header file? It can be put in > > > > a header file > > > > > > Hm looks like the bots disagree. I suppose a declaration right above definition > > > in lib/vsprintf.c would silence them, but I'll leave it to printk maintainers if > > > they would prefer that way or traditionally > > > include/linux/kernel.h > > > > I slightly prefer to put it into kernel.h. I expect that some more > > debugging facilities would want to enable this in the future. > > But I would accept even the "ugly" declaration in vsprintf.c. > > Ok no problem. Would printk.h be more appropriate? kernel.h looks more appropriate to me. vsprintf-related are there and no_hash_pointers is implemented and handled in vsprintf.c. Best Regards, Petr
