On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote: > diff --git a/kernel/resource.c b/kernel/resource.c > index 627e61b0c124..da137553b83e 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -783,7 +783,7 @@ struct resource *lookup_resource(struct resource *root, resource_size_t start) > > return res; > } > - > +EXPORT_SYMBOL(lookup_resource); NAK on hiding random exports in a driver patch. This needs to be a proper patch with a proper rationale, a kerneldoc comment and use EXPORT_SYMBOL_GPL. And even then it smells rather fishy, but I'll wait for the rationale.