On Thu, 27 May 2021 09:10:31 +0100 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Fri, May 14, 2021 at 03:24:26PM +0100, Matthew Wilcox wrote: > > On Fri, May 14, 2021 at 01:56:46PM +0200, Vlastimil Babka wrote: > > > Nitpick: function names in subject should IMHO also end with (). But not a > > > reason for resend all patches that don't... > > > > Hm, I thought it was preferred to not do that. I can fix it > > easily enough when I go through and add the R-b. > > I hate the pointless (). Some maintainers insist on it. No matter > what you do you'll make some folks happy and others not. I prefer it. It succinctly says "this identifier is a function" which is useful info. I get many changelogs saying "the foo function" or "the function foo". "foo()" is better.
