This is a note to let you know that I've just added the patch titled
mm, vmstat: drop zone->lock in /proc/pagetypeinfo
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mm-vmstat-drop-zone-lock-in-proc-pagetypeinfo.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Thu May 27 11:14:38 AM CEST 2021
From: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx>
Date: Wed, 26 May 2021 10:46:13 -0700
Subject: mm, vmstat: drop zone->lock in /proc/pagetypeinfo
To: stable@xxxxxxxxxxxxxxx
Cc: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Lameter <clameter@xxxxxxx>, Mel Gorman <mel@xxxxxxxxx>, Andy Whitcroft <apw@xxxxxxxxxxxx>, Aruna Ramakrishna <aruna.ramakrishna@xxxxxxxxxx>, Khalid Aziz <khalid.aziz@xxxxxxxxxx>
Message-ID: <20210526174613.339990-1-stephen.s.brennan@xxxxxxxxxx>
From: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx>
Commit 93b3a674485f6a4b8ffff85d1682d5e8b7c51560 upstream
Commit 93b3a674485f ("mm,vmstat: reduce zone->lock holding time by
/proc/pagetypeinfo") upstream caps the number of iterations over each
free_list at 100,000, and also drops the zone->lock in between each
migrate type. Capping the iteration count alters the file contents in
some cases, which means this approach may not be suitable for stable
backports.
However, dropping zone->lock in between migrate types (and, as a result,
page orders) will not change the /proc/pagetypeinfo file contents. It
can significantly reduce the length of time spent with IRQs disabled,
which can prevent missed interrupts or soft lockups which we have
observed on systems with particularly large memory.
Thus, this commit is a modified version of the upstream one which only
drops the lock in between migrate types.
Fixes: 467c996c1e19 ("Print out statistics in relation to fragmentation avoidance to /proc/pagetypeinfo")
Signed-off-by: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx>
Reviewed-by: Aruna Ramakrishna <aruna.ramakrishna@xxxxxxxxxx>
Reviewed-by: Khalid Aziz <khalid.aziz@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
mm/vmstat.c | 3 +++
1 file changed, 3 insertions(+)
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1313,6 +1313,9 @@ static void pagetypeinfo_showfree_print(
list_for_each(curr, &area->free_list[mtype])
freecount++;
seq_printf(m, "%6lu ", freecount);
+ spin_unlock_irq(&zone->lock);
+ cond_resched();
+ spin_lock_irq(&zone->lock);
}
seq_putc(m, '\n');
}
Patches currently in stable-queue which might be from stephen.s.brennan@xxxxxxxxxx are
queue-4.14/mm-vmstat-drop-zone-lock-in-proc-pagetypeinfo.patch
