On 5/25/21 8:19 PM, Muchun Song wrote: > On Wed, May 26, 2021 at 7:31 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote: >> >> Here is a modification to the reservation tracking for fixup on errors. >> It is a more general change, but should work for the hugetlb_mcopy_pte_atomic >> case as well. >> >> Perhaps use this as a prerequisite for your fix(es)? Pretty sure this >> will eliminate the need for the call to hugetlb_unreserve_pages. > > Hi Mike, > > It seems like someone is fixing a bug, right? Maybe a link should be > placed in the cover letter so that someone can know what issue > we are facing. > Thanks Muchun, I wanted to first see if these patches would work in the code Mina is modifying. If this works for Mina, then a more formal patch and request for inclusion will be sent. I believe this issue has existed since the introduction of hugetlb reservations in v2.6.18. Since the bug only shows up when we take error paths, the issue may not have been observed. Mina found a similar issue in an error path which could also expose this issue. -- Mike Kravetz
