On Fri, May 21, 2021 at 01:10:33PM +0200, Uladzislau Rezki (Sony) wrote:
> +static inline unsigned int
> +vm_area_alloc_pages(gfp_t gfp, int nid, unsigned int page_order,
> + unsigned long nr_small_pages, struct page **pages)
(at least) two tabs here, please, otherwise the argument list is at
the same indentation as the code which trips up my parser. some people
like to match the opening bracket, but that always feels like more work
than it's worth. fwiw, i'd format it like this:
static inline unsigned int vm_area_alloc_pages(gfp_t gfp, int nid,
unsigned int order, unsigned long nr_pages, struct page **pages)
{
...
(yes, i renamed some of the variables there; overly long variable names
are painful)
The rest of the patch looks good.
Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
