On 2021/5/18 22:37, Matthew Wilcox wrote: > On Tue, May 18, 2021 at 09:53:49PM +0800, Miaohe Lin wrote: >> Since commit 55c653b71e8c ("mm: stop accounting shadow entries"), >> nr_shadows is not used anymore. >> >> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > > Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > >> +++ b/mm/swap_state.c >> @@ -114,7 +114,6 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry, >> SetPageSwapCache(page); >> >> do { >> - unsigned long nr_shadows = 0; >> > > Perhaps delete the blank line as well? Will do. Many thanks for the review. > > . >