On Thu, Oct 27, 2011 at 10:50:25AM +0200, Mel Gorman wrote: > On Mon, Oct 24, 2011 at 11:10:35AM -0500, Dimitri Sivanich wrote: > > Avoid false sharing of the vm_stat array. > > > > This was found to adversely affect tmpfs I/O performance. > > > > I think this fix is overly simplistic. In a lesson on why I should not even try reviewing while attending conferences, I totally misread what the patch is doing. It's aligning the array to avoid false sharing with other global data, not aligning each element. This is reasonable. Acked-by: Mel Gorman <mel@xxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>