Re: [patch 1/5]thp: improve the error code path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-10-25 at 19:44 +0800, Andrea Arcangeli wrote:
> Hello,
> 
> On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote:
> > +#ifdef CONFIG_SYSFS
> > +	sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> > +remove_hp_group:
> > +	sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> > +delete_obj:
> > +	kobject_put(hugepage_kobj);
> >  out:
> > +#endif
> 
> Adding an ifdef is making the code worse, the whole point of having
> these functions become noops at build time is to avoid having to add
> ifdefs in the callers.
yes, but hugepage_attr_group is defined in CONFIG_SYSFS. And the
functions are inline functions. They really should be a '#define xxx'.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]