On Tue, May 11, 2021 at 02:58:18AM +0100, Matthew Wilcox wrote: > On Mon, May 10, 2021 at 06:52:38PM -0700, Andrew Morton wrote: > > On Mon, 10 May 2021 12:33:42 +0200 Uladzislau Rezki <urezki@xxxxxxxxx> wrote: > > > > > Please find the v4 version of the patch that is in question: > > > > > > >From 7e27e4ac8f299ae244e9e0e90e0292ae2c08d37d Mon Sep 17 00:00:00 2001 > > > From: "Uladzislau Rezki (Sony)" <urezki@xxxxxxxxx> > > > Date: Sat, 8 May 2021 23:41:21 +0200 > > > Subject: [PATCH v4 1/1] mm/vmalloc: Print a warning message first on failure > > > > Added, thanks. > > > > Matthew has a point of course, but I do think that any console driver > > which tries to allocate memory within the cotext of printk() is so > > pathetic that it isn't worth compromising core code to cater for it... > > I'm fine with v4 of this patch, fwiw. I saw no advantage to the earlier > version, but now that the advantage has been explained, the advantage > outweighs the disadvantage. Thanks! The point about an extra memory for printk is correct. From the other hand i am not able to recall issues related to lack of memory for printk() to emit a message. At least on our mobile devices i have not seen such scenarios. -- Vlad Rezki
