Re: [PATCH v3 2/2] secretmem: optimize page_is_secretmem()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



<shakeelb@xxxxxxxxxx>,Shuah Khan <shuah@xxxxxxxxxx>,Thomas Gleixner <tglx@xxxxxxxxxxxxx>,Tycho Andersen <tycho@xxxxxxxx>,Will Deacon <will@xxxxxxxxxx>,Yury Norov <yury.norov@xxxxxxxxx>,linux-api@xxxxxxxxxxxxxxx,linux-arch@xxxxxxxxxxxxxxx,linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,linux-fsdevel@xxxxxxxxxxxxxxx,linux-mm@xxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx,linux-kselftest@xxxxxxxxxxxxxxx,linux-nvdimm@xxxxxxxxxxxx,linux-riscv@xxxxxxxxxxxxxxxxxxx,x86@xxxxxxxxxx,kernel test robot <oliver.sang@xxxxxxxxx>
From: Mike Rapoport <rppt@xxxxxxxxxx>
Message-ID: <48E0FD56-6084-48B0-A59C-D2E2BF40DDA2@xxxxxxxxxx>



On May 7, 2021 6:01:44 PM GMT+03:00, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>On Tue, Apr 20, 2021 at 06:00:49PM +0300, Mike Rapoport wrote:
>> +	mapping = (struct address_space *)
>> +		((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS);
>> +
>> +	if (mapping != page->mapping)
>> +		return false;
>> +
>> +	return page->mapping->a_ops == &secretmem_aops;
>
>... why do you go back to page->mapping here?
>
>	return mapping->a_ops == &secretmem_aops

Ok
-- 
Sincerely yours,
Mike





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux