On Sun, 2011-10-23 at 22:19 -0700, Andi Kleen wrote: > Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> writes: > > > We need a cpumask to track cpus with per cpu cache pages > > to know which cpu to whack during flush_all. For > > CONFIG_CPUMASK_OFFSTACK=n we allocate the mask on stack. > > For CONFIG_CPUMASK_OFFSTACK=y we don't want to call kmalloc > > on the flush_all path, so we preallocate per kmem_cache > > on cache creation and use it in flush_all. > > What's the problem with calling kmalloc in flush_all? > That's a slow path anyways, isn't it? > > I believe the IPI functions usually allocate anyways. > > So maybe you can do that much simpler. You'd be trying to allocate memory in a memory shrinking path. -- Sasha. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>