Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210505] [cannot apply to hnaz-linux-mm/master xfs-linux/for-next tip/perf/core shaggy/jfs-next block/for-next linus/master asm-generic/master v5.12 v5.12-rc8 v5.12-rc7 v5.12] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Memory-folios/20210506-014108 base: 29955e0289b3255c5f609a7564a0f0bb4ae35c7a config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0780b0addad735d2cceb3680d49f54f8618e1334 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Memory-folios/20210506-014108 git checkout 0780b0addad735d2cceb3680d49f54f8618e1334 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/swap.h:9, from fs/iomap/buffered-io.c:16: include/linux/memcontrol.h: In function 'folio_uncharge_cgroup': include/linux/memcontrol.h:1213:42: error: parameter name omitted 1213 | static inline void folio_uncharge_cgroup(struct folio *) | ^~~~~~~~~~~~~~ fs/iomap/buffered-io.c: In function '__iomap_write_end': >> fs/iomap/buffered-io.c:645:2: error: implicit declaration of function 'flush_dcache_folio'; did you mean 'flush_dcache_page'? [-Werror=implicit-function-declaration] 645 | flush_dcache_folio(folio); | ^~~~~~~~~~~~~~~~~~ | flush_dcache_page cc1: some warnings being treated as errors vim +645 fs/iomap/buffered-io.c 640 641 static size_t __iomap_write_end(struct inode *inode, loff_t pos, size_t len, 642 size_t copied, struct folio *folio) 643 { 644 struct iomap_page *iop = to_iomap_page(folio); > 645 flush_dcache_folio(folio); 646 647 /* 648 * The blocks that were entirely written will now be uptodate, so we 649 * don't have to worry about a readpage reading them and overwriting a 650 * partial write. However if we have encountered a short write and only 651 * partially written into a block, it will not be marked uptodate, so a 652 * readpage might come in and destroy our partial write. 653 * 654 * Do the simplest thing, and just treat any short write to a non 655 * uptodate page as a zero-length write, and force the caller to redo 656 * the whole thing. 657 */ 658 if (unlikely(copied < len && !folio_uptodate(folio))) 659 return 0; 660 iomap_set_range_uptodate(folio, iop, offset_in_folio(folio, pos), len); 661 filemap_dirty_folio(inode->i_mapping, folio); 662 return copied; 663 } 664 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
