Hi, I just noticed return 0 was missing after rolling back *nr, that's not ok as then gup_fast wouldn't abort and it would put pages in the wrong offset in the array I think... This isn't related to the recent changes, it was the same in 2.6.37. I don't think it's ok to return 1 after rolling back *nr. These next two are incremental with the previous. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>