On Mon, 17 Oct 2011 14:21:07 +0200
Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote:
> > > +
> > > +void free_contig_pages(unsigned long pfn, unsigned nr_pages)
> > > +{
> > > + struct page *page = pfn_to_page(pfn);
> > > +
> > > + while (nr_pages--) {
> > > + __free_page(page);
> > > + ++pfn;
> > > + if (likely(zone_pfn_same_memmap(pfn - 1, pfn)))
> > > + ++page;
> > > + else
> > > + page = pfn_to_page(pfn);
> > > + }
> > > +}
> >
> > You're sure these functions don't need EXPORT_SYMBOL()? Maybe the
> > design is that only DMA core calls into here (if so, that's good).
>
> Drivers should not call it, it is intended to be used by low-level DMA
> code.
OK, thanks for checking.
> Do you think that a comment about missing EXPORT_SYMBOL is
> required?
No. If someone later wants to use these from a module then we can look
at their reasons and make a decision at that time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>