On Fri, Apr 16, 2021 at 01:14:04PM +0800, Muchun Song wrote: > lruvec_holds_page_lru_lock() doesn't check anything about locking and is > used to check whether the page belongs to the lruvec. So rename it to > page_matches_lruvec(). > > Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> The rename makes sense, since the previous name was defined by a specific use case rather than what it does. That said, it did imply a lock context that makes the test result stable. Without that the function could use a short comment, IMO. How about: /* Test requires a stable page->memcg binding, see page_memcg() */ With that, Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
