On Tue, Apr 13, 2021 at 09:20:26PM -0400, Waiman Long wrote: > The object stock data stored in struct memcg_stock_pcp are independent > of the other page based data stored there. Separating them out into > their own struct to highlight the independency. > > Signed-off-by: Waiman Long <longman@xxxxxxxxxx> > Acked-by: Roman Gushchin <guro@xxxxxx> > Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx> > --- > mm/memcontrol.c | 41 ++++++++++++++++++++++++++--------------- > 1 file changed, 26 insertions(+), 15 deletions(-) It's almost twice more code, and IMO not any clearer. Plus it adds some warts: int dummy[0], redundant naming in stock->obj.cached_objcg, this_cpu_ptr() doesn't really need a wrapper etc.