On 15.04.21 13:41, Michal Hocko wrote:
On Thu 15-04-21 12:35:40, Oscar Salvador wrote:
Pages allocated after boot get its private field cleared by means
of post_alloc_hook().
You surely meant to say s@boot@page/cma allocator@ here
I think this also includes allocating gigantic pages via
alloc_contig_pages() directly. post_alloc_hook() covers both.
Pages allocated during boot, that is directly from the memblock allocator,
get cleared by paging_init()->..->memmap_init_zone->..->__init_single_page()
before any memblock allocation.
Based on this ground, let us remove the clearing of the flag from
prep_new_huge_page() as it is not needed.
I would also mention that this is a leftover from 6c0371490140
("hugetlb: convert PageHugeFreed to HPageFreed flag"). Previously the
explicit clearing was necessary because compound allocations do not get
this initialization (see prep_compound_page).
Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
with that
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
--
Thanks,
David / dhildenb
