On Mon, Apr 12, 2021 at 10:00:15AM +0200, Peter Zijlstra wrote: > --- a/drivers/xen/grant-table.c > +++ b/drivers/xen/grant-table.c > @@ -1591,6 +1591,43 @@ int gnttab_init(void) > } > EXPORT_SYMBOL_GPL(gnttab_init); > > +#include <xen/gntdev.h> > +#include "gntdev-common.h" Can't we keep the includes at the top of the file? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>