On Tue, Apr 06, 2021 at 03:47:12PM +0100, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 03:40:22PM +0100, Matthew Wilcox wrote: > > On Tue, Apr 06, 2021 at 03:31:50PM +0100, Christoph Hellwig wrote: > > > > > As Christoph, I'm not a fan of this :/ > > > > > > > > What would you prefer? > > > > > > Looking at your full folio series on git.infradead.org, there are a > > > total of 12 references to non-page members of struct folio, assuming > > > my crude grep that expects a folio to be named folio did not miss any. > > > > Hmm ... I count more in the filesystems: > > I only counted the ones that you actually did convert. > > This add about 80 more. IMHO still not worth doing the union. I'd > rather sort this out properl if/when the structures get properly split. Assuming we're getting rid of them all though, we have to include: $ git grep 'page->mapping' fs |wc -l 358 $ git grep 'page->index' fs |wc -l 355
