On Thu, Apr 1, 2021 at 12:04 PM 'Daniel Latypov' via KUnit Development <kunit-dev@xxxxxxxxxxxxxxxx> wrote: > > On Thu, Apr 1, 2021 at 2:16 AM 'Marco Elver' via KUnit Development > <kunit-dev@xxxxxxxxxxxxxxxx> wrote: [...] > > #else > > static inline bool slab_add_kunit_errors(void) { return false; } > > #endif > > > > And anywhere you want to increase the error count, you'd call > > slab_add_kunit_errors(). > > > > Another benefit of this approach is that if KUnit is disabled, there is > > zero overhead and no additional code generated (vs. the current > > approach). > > The resource approach looks really good, but... > You'd be picking up a dependency on > https://lore.kernel.org/linux-kselftest/20210311152314.3814916-2-dlatypov@xxxxxxxxxx/ > current->kunit_test will always be NULL unless CONFIG_KASAN=y && > CONFIG_KUNIT=y at the moment. > My patch drops the CONFIG_KASAN requirement and opens it up to all tests. > > At the moment, it's just waiting another look over from Brendan or David. > Any ETA on that, folks? :) I just gave a "Reviewed-by" and sent it off to Shuah. Should be available in 5.13. Cheers