On Mon, Mar 22, 2021 at 08:11:15PM +0000, Matthew Wilcox (Oracle) wrote: > -void __fprop_inc_percpu_max(struct fprop_global *p, > - struct fprop_local_percpu *pl, int max_frac) > +void __fprop_add_percpu_max(struct fprop_global *p, > + struct fprop_local_percpu *pl, int max_frac, long nr) > { > if (unlikely(max_frac < FPROP_FRAC_BASE)) { Oh, I meant to ask ... should this change? Should it be: if (unlikely(max_frac < FPROP_FRAC_BASE / nr)) (or something similar that copes with overflow properly) I must confess to not understanding exactly how flex_proportions works.