Vivek Goyal <vgoyal@xxxxxxxxxx> writes: > > Will it make sense to break down this work in two patch series. First > push IO less balance dirty pages and then all the complicated pieces > of ratelimits. I would be wary against too much refactoring of well tested patchkits. I've seen too many cases where this can add nasty and subtle bugs, given that our unit test coverage is usually relatively poor. For example the infamous "absolute path names became twice as slow" bug was very likely introduced in such a refactoring of a large VFS patchkit. While it's generally good to make things easier for reviewers too much of a good thing can be quite bad. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>