Re: [PATCH v5 24/27] mm/filemap: Convert wait_on_page_bit to wait_on_folio_bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210319]
[cannot apply to linux/master linus/master hnaz-linux-mm/master v5.12-rc3 v5.12-rc2 v5.12-rc1 v5.12-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Memory-Folios/20210320-134732
base:    f00397ee41c79b6155b9b44abd0055b2c0621349
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/39199d654ac6a6bbaba1620337574ec74adee8fe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Memory-Folios/20210320-134732
        git checkout 39199d654ac6a6bbaba1620337574ec74adee8fe
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   fs/afs/write.c: In function 'afs_page_mkwrite':
>> fs/afs/write.c:849:6: error: implicit declaration of function 'wait_on_page_bit_killable'; did you mean 'wait_on_folio_bit_killable'? [-Werror=implicit-function-declaration]
     849 |      wait_on_page_bit_killable(page, PG_fscache) < 0)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
         |      wait_on_folio_bit_killable
   cc1: some warnings being treated as errors


vim +849 fs/afs/write.c

9b3f26c9110dce David Howells           2009-04-03  827  
9b3f26c9110dce David Howells           2009-04-03  828  /*
9b3f26c9110dce David Howells           2009-04-03  829   * notification that a previously read-only page is about to become writable
9b3f26c9110dce David Howells           2009-04-03  830   * - if it returns an error, the caller will deliver a bus error signal
9b3f26c9110dce David Howells           2009-04-03  831   */
0722f186205976 Souptick Joarder        2018-08-23  832  vm_fault_t afs_page_mkwrite(struct vm_fault *vmf)
9b3f26c9110dce David Howells           2009-04-03  833  {
721597fd1aa668 David Howells           2020-10-20  834  	struct page *page = thp_head(vmf->page);
1cf7a1518aefa6 David Howells           2017-11-02  835  	struct file *file = vmf->vma->vm_file;
1cf7a1518aefa6 David Howells           2017-11-02  836  	struct inode *inode = file_inode(file);
1cf7a1518aefa6 David Howells           2017-11-02  837  	struct afs_vnode *vnode = AFS_FS_I(inode);
1cf7a1518aefa6 David Howells           2017-11-02  838  	unsigned long priv;
9b3f26c9110dce David Howells           2009-04-03  839  
721597fd1aa668 David Howells           2020-10-20  840  	_enter("{{%llx:%llu}},{%lx}", vnode->fid.vid, vnode->fid.vnode, page->index);
9b3f26c9110dce David Howells           2009-04-03  841  
1cf7a1518aefa6 David Howells           2017-11-02  842  	sb_start_pagefault(inode->i_sb);
9b3f26c9110dce David Howells           2009-04-03  843  
1cf7a1518aefa6 David Howells           2017-11-02  844  	/* Wait for the page to be written to the cache before we allow it to
1cf7a1518aefa6 David Howells           2017-11-02  845  	 * be modified.  We then assume the entire page will need writing back.
1cf7a1518aefa6 David Howells           2017-11-02  846  	 */
77837f50249aa4 David Howells           2020-02-06  847  #ifdef CONFIG_AFS_FSCACHE
721597fd1aa668 David Howells           2020-10-20  848  	if (PageFsCache(page) &&
721597fd1aa668 David Howells           2020-10-20 @849  	    wait_on_page_bit_killable(page, PG_fscache) < 0)
77837f50249aa4 David Howells           2020-02-06  850  		return VM_FAULT_RETRY;
77837f50249aa4 David Howells           2020-02-06  851  #endif
9b3f26c9110dce David Howells           2009-04-03  852  
5dc1af598f0274 Matthew Wilcox (Oracle  2021-03-20  853) 	if (wait_on_folio_writeback_killable(page_folio(page)))
1cf7a1518aefa6 David Howells           2017-11-02  854  		return VM_FAULT_RETRY;
1cf7a1518aefa6 David Howells           2017-11-02  855  
721597fd1aa668 David Howells           2020-10-20  856  	if (lock_page_killable(page) < 0)
1cf7a1518aefa6 David Howells           2017-11-02  857  		return VM_FAULT_RETRY;
1cf7a1518aefa6 David Howells           2017-11-02  858  
1cf7a1518aefa6 David Howells           2017-11-02  859  	/* We mustn't change page->private until writeback is complete as that
1cf7a1518aefa6 David Howells           2017-11-02  860  	 * details the portion of the page we need to write back and we might
1cf7a1518aefa6 David Howells           2017-11-02  861  	 * need to redirty the page if there's a problem.
1cf7a1518aefa6 David Howells           2017-11-02  862  	 */
721597fd1aa668 David Howells           2020-10-20  863  	wait_on_page_writeback(page);
1cf7a1518aefa6 David Howells           2017-11-02  864  
721597fd1aa668 David Howells           2020-10-20  865  	priv = afs_page_dirty(page, 0, thp_size(page));
f86726a69dec5d David Howells           2020-10-22  866  	priv = afs_page_dirty_mmapped(priv);
721597fd1aa668 David Howells           2020-10-20  867  	if (PagePrivate(page)) {
721597fd1aa668 David Howells           2020-10-20  868  		set_page_private(page, priv);
721597fd1aa668 David Howells           2020-10-20  869  		trace_afs_page_dirty(vnode, tracepoint_string("mkwrite+"), page);
721597fd1aa668 David Howells           2020-10-20  870  	} else {
721597fd1aa668 David Howells           2020-10-20  871  		attach_page_private(page, (void *)priv);
721597fd1aa668 David Howells           2020-10-20  872  		trace_afs_page_dirty(vnode, tracepoint_string("mkwrite"), page);
721597fd1aa668 David Howells           2020-10-20  873  	}
bb413489288e4e David Howells           2020-06-12  874  	file_update_time(file);
1cf7a1518aefa6 David Howells           2017-11-02  875  
1cf7a1518aefa6 David Howells           2017-11-02  876  	sb_end_pagefault(inode->i_sb);
1cf7a1518aefa6 David Howells           2017-11-02  877  	return VM_FAULT_LOCKED;
9b3f26c9110dce David Howells           2009-04-03  878  }
4343d00872e1de David Howells           2017-11-02  879  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux