Hi Rafael, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-linux-mm/master] url: https://github.com/0day-ci/linux/commits/Rafael-Aquini/mm-slab_common-provide-slab_merge-option-for-IS_ENABLED-CONFIG_SLAB_MERGE_DEFAULT-builds/20210320-032434 base: https://github.com/hnaz/linux-mm master config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d6cb7528eaf0afbcb48bee452f7fa395938bd559 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Rafael-Aquini/mm-slab_common-provide-slab_merge-option-for-IS_ENABLED-CONFIG_SLAB_MERGE_DEFAULT-builds/20210320-032434 git checkout d6cb7528eaf0afbcb48bee452f7fa395938bd559 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5, from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/slab.h:15, from mm/slab_common.c:7: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/page.h:60, from arch/m68k/include/asm/thread_info.h:6, from include/linux/thread_info.h:38, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/mmzone.h:8, from include/linux/gfp.h:6, from include/linux/slab.h:15, from mm/slab_common.c:7: mm/internal.h: In function 'mem_map_next': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ mm/internal.h:456:8: note: in expansion of macro 'pfn_valid' 456 | if (!pfn_valid(pfn)) | ^~~~~~~~~ In file included from include/linux/printk.h:6, from include/linux/kernel.h:15, from include/asm-generic/bug.h:20, from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/slab.h:15, from mm/slab_common.c:7: mm/slab_common.c: At top level: >> include/linux/init.h:254:20: error: redefinition of '__setup_str_setup_slab_nomerge' 254 | static const char __setup_str_##unique_id[] __initconst \ | ^~~~~~~~~~~~ include/linux/init.h:262:2: note: in expansion of macro '__setup_param' 262 | __setup_param(str, fn, fn, 0) | ^~~~~~~~~~~~~ mm/slab_common.c:84:1: note: in expansion of macro '__setup' 84 | __setup("slab_merge", setup_slab_nomerge); | ^~~~~~~ include/linux/init.h:254:20: note: previous definition of '__setup_str_setup_slab_nomerge' was here 254 | static const char __setup_str_##unique_id[] __initconst \ | ^~~~~~~~~~~~ include/linux/init.h:262:2: note: in expansion of macro '__setup_param' 262 | __setup_param(str, fn, fn, 0) | ^~~~~~~~~~~~~ mm/slab_common.c:83:1: note: in expansion of macro '__setup' 83 | __setup("slab_nomerge", setup_slab_nomerge); | ^~~~~~~ >> include/linux/init.h:256:33: error: redefinition of '__setup_setup_slab_nomerge' 256 | static struct obs_kernel_param __setup_##unique_id \ | ^~~~~~~~ include/linux/init.h:262:2: note: in expansion of macro '__setup_param' 262 | __setup_param(str, fn, fn, 0) | ^~~~~~~~~~~~~ mm/slab_common.c:84:1: note: in expansion of macro '__setup' 84 | __setup("slab_merge", setup_slab_nomerge); | ^~~~~~~ include/linux/init.h:256:33: note: previous definition of '__setup_setup_slab_nomerge' was here 256 | static struct obs_kernel_param __setup_##unique_id \ | ^~~~~~~~ include/linux/init.h:262:2: note: in expansion of macro '__setup_param' 262 | __setup_param(str, fn, fn, 0) | ^~~~~~~~~~~~~ mm/slab_common.c:83:1: note: in expansion of macro '__setup' 83 | __setup("slab_nomerge", setup_slab_nomerge); | ^~~~~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on DISCONTIGMEM || NUMA Selected by - SINGLE_MEMORY_CHUNK && MMU vim +/__setup_setup_slab_nomerge +256 include/linux/init.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 246 ^1da177e4c3f41 Linus Torvalds 2005-04-16 247 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 248 * Only for really core code. See moduleparam.h for the normal way. ^1da177e4c3f41 Linus Torvalds 2005-04-16 249 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 250 * Force the alignment so the compiler doesn't space elements of the ^1da177e4c3f41 Linus Torvalds 2005-04-16 251 * obs_kernel_param "array" too far apart in .init.setup. ^1da177e4c3f41 Linus Torvalds 2005-04-16 252 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 253 #define __setup_param(str, unique_id, fn, early) \ fd6c3a8dc44329 Jan Beulich 2009-03-12 @254 static const char __setup_str_##unique_id[] __initconst \ fd6c3a8dc44329 Jan Beulich 2009-03-12 255 __aligned(1) = str; \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 @256 static struct obs_kernel_param __setup_##unique_id \ 3ff6eecca4e5c4 Adrian Bunk 2008-01-24 257 __used __section(.init.setup) \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 258 __attribute__((aligned((sizeof(long))))) \ ^1da177e4c3f41 Linus Torvalds 2005-04-16 259 = { __setup_str_##unique_id, fn, early } ^1da177e4c3f41 Linus Torvalds 2005-04-16 260 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
