On Tue, 2011-10-04 at 12:35 -0700, Dave Hansen wrote: > On Sat, 2011-10-01 at 12:33 -0700, Joe Perches wrote: > > On Fri, 2011-09-30 at 17:08 -0700, Dave Hansen wrote: > > > Instead of explicitly storing the entire string for each > > > possible units, just store the thing that varies: the > > > first character. > > trivia > I'm not sure what you mean by that. that what followed wasn't a declaration of defect, just trivial. > > > diff -puN lib/string_helpers.c~string_get_size-pow2 lib/string_helpers.c > > > --- linux-2.6.git/lib/string_helpers.c~string_get_size-pow2 2011-09-30 16:50:31.628981352 -0700 > > > +++ linux-2.6.git-dave/lib/string_helpers.c 2011-09-30 17:04:02.211607364 -0700 > > > @@ -8,6 +8,23 @@ > > > #include <linux/module.h> > > > #include <linux/string_helpers.h> > > > > > > +static const char byte_units[] = "_KMGTPEZY"; > > > > u64 could be up to ~1.8**19 decimal > > zetta and yotta are not possible or necessary. > > u128 maybe someday, but then other changes > > would be necessary too. > > Right, but we're only handling u64. So the declaration should be: static const char byte_units[] = " KMGTPE"; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>