From: Bin Lai <robinlai@xxxxxxxxxxx> From: Bin Lai <robinlai@xxxxxxxxxxx> The oc->chosen is used by oom implementation, and the caller does not initialize this variable. If the tasks of memcg are all unkillable, oom_evaluate_task cann't choose any task, and the oc->chosen will be a wild pointer. So we should initialize oc->chosen before calling oom_evaluate_task. Signed-off-by: Bin Lai <robinlai@xxxxxxxxxxx> Reviewed-by: Jiang Biao <benbjiang@xxxxxxxxxxx> diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 9efaf43..0658a30 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -366,6 +366,7 @@ static int oom_evaluate_task(struct task_struct *task, void *arg) static void select_bad_process(struct oom_control *oc) { oc->chosen_points = LONG_MIN; + oc->chosen = NULL; if (is_memcg_oom(oc)) mem_cgroup_scan_tasks(oc->memcg, oom_evaluate_task, oc); -- 1.8.3.1