Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Muchun Song <songmuchun@xxxxxxxxxxxxx>
Subject: Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
From: Michal Hocko <mhocko@xxxxxxxx>
Date: Thu, 11 Mar 2021 13:16:37 +0100
Cc: Jonathan Corbet <corbet@xxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, bp@xxxxxxxxx, x86@xxxxxxxxxx, hpa@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, luto@xxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, paulmck@xxxxxxxxxx, mchehab+huawei@xxxxxxxxxx, pawan.kumar.gupta@xxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, oneukum@xxxxxxxx, anshuman.khandual@xxxxxxx, jroedel@xxxxxxx, Mina Almasry <almasrymina@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, "Song Bao Hua (Barry Song)" <song.bao.hua@xxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, HORIGUCHI NAOYA(堀口直也) <naoya.horiguchi@xxxxxxx>, Joao Martins <joao.m.martins@xxxxxxxxxx>, Xiongchun duan <duanxiongchun@xxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Linux Memory Management List <linux-mm@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Miaohe Lin <linmiaohe@xxxxxxxxxx>, Chen Huang <chenhuang5@xxxxxxxxxx>, Bodeddula Balasubramaniam <bodeddub@xxxxxxxxxx>
In-reply-to: <CAMZfGtX3pUmPOY1ieVQubnBKHZoOxfp-ARsPigYZpc=-UiiNjg@mail.gmail.com>
References: <20210308102807.59745-1-songmuchun@bytedance.com> <20210308102807.59745-10-songmuchun@bytedance.com> <YEjoozshsvKeMAAu@dhcp22.suse.cz> <CAMZfGtV1Fp1RiQ64c9RrMmZ+=EwjGRHjwL8Wx3Q0YRWbbKF6xg@mail.gmail.com> <YEnbBPviwU6N2RzK@dhcp22.suse.cz> <CAMZfGtW5uHYiA_1an3W-jEmemsoN3Org7JwieeE2V271wh9X-A@mail.gmail.com> <YEnlRlLJD1bK/Dup@dhcp22.suse.cz> <CAMZfGtX3pUmPOY1ieVQubnBKHZoOxfp-ARsPigYZpc=-UiiNjg@mail.gmail.com>

On Thu 11-03-21 18:00:09, Muchun Song wrote:
[...]
> Sorry. I am confused why you disagree with this change.
> It does not bring any disadvantages.

Because it is adding a code which is not really necessary and which will
have to be maintained. Think of future changes which would need to grow
more of these. Hugetlb code paths shouldn't really think about size of
the struct page.
-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Oscar Salvador
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Muchun Song

References:
- [PATCH v18 0/9] Free some vmemmap pages of HugeTLB page
  - From: Muchun Song
- [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Muchun Song
- Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Michal Hocko
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Muchun Song
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Michal Hocko
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Muchun Song
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Michal Hocko
- Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
  - From: Muchun Song

Prev by Date: Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
Next by Date: Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page
Previous by thread: Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
Next by thread: Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]