Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
Subject: Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Thu, 11 Mar 2021 09:46:30 +0100
Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Michal Hocko <mhocko@xxxxxxxx>, "Paul E . McKenney" <paulmck@xxxxxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, tglx@xxxxxxxxxxxxx, john.ogness@xxxxxxxxxxxxx, urezki@xxxxxxxxx, ast@xxxxxx, Eric Dumazet <edumazet@xxxxxxxxxx>, Mina Almasry <almasrymina@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20210311021321.127500-1-mike.kravetz@oracle.com>
References: <20210311021321.127500-1-mike.kravetz@oracle.com>

On Wed, Mar 10, 2021 at 06:13:21PM -0800, Mike Kravetz wrote:
> from irq context.  Changing the check in the code from !in_task to
> in_atomic would handle the situations when called with irqs disabled.

It does not. local_irq_disable() does not change preempt_count().

Follow-Ups:
- Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
  - From: Michal Hocko

References:
- [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
  - From: Mike Kravetz

Prev by Date: Re: [External] Re: [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c
Next by Date: Re: [PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users
Previous by thread: Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
Next by thread: Re: [PATCH] hugetlb: select PREEMPT_COUNT if HUGETLB_PAGE for in_atomic use
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux