On Tue, Mar 09, 2021 at 10:34:51AM -0800, Dave Hansen wrote: > On 3/9/21 9:41 AM, Oscar Salvador wrote: > > We never get to allocate 1GB pages when mapping the vmemmap range. > > Drop the dead code both for the aligned and unaligned cases and leave > > only the direct map handling. > > I was hoping to seem some more meat in this changelog, possibly some of > what David Hildenbrand said in the v4 thread about this patch. > Basically, we don't have code to allocate 1G mappings because it isn't > clear that it would be worth the complexity, and it might also waste memory. > > I'm fine with the code, but I would appreciate a beefed-up changelog: > > Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Since I had to do another pass to fix up some compilaton errors, I added a bit more of explanation in that regard. Thanks! -- Oscar Salvador SUSE L3
