On 3/1/21 11:53 AM, Christoph Hellwig wrote: > On Mon, Mar 01, 2021 at 11:20:53AM +0530, Anshuman Khandual wrote: >> HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual >> platform subscribing it. Instead just make it generic. >> >> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> >> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> >> Cc: Paul Mackerras <paulus@xxxxxxxxx> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: Christoph Hellwig <hch@xxxxxx> >> Cc: linux-ia64@xxxxxxxxxxxxxxx >> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx >> Cc: linux-mm@xxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Suggested-by: Christoph Hellwig <hch@xxxxxx> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> >> --- >> This change was originally suggested in an earilier discussion. This >> applies on v5.12-rc1 and has been build tested on all applicable >> platforms i.e ia64 and powerpc. >> >> https://patchwork.kernel.org/project/linux-mm/patch/1613024531-19040-3-git-send-email-anshuman.khandual@xxxxxxx/ >> >> arch/ia64/Kconfig | 6 +----- >> arch/powerpc/Kconfig | 6 +----- >> mm/Kconfig | 8 ++++++++ >> 3 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig >> index 2ad7a8d29fcc..6b3e3f6c29ae 100644 >> --- a/arch/ia64/Kconfig >> +++ b/arch/ia64/Kconfig >> @@ -32,6 +32,7 @@ config IA64 >> select TTY >> select HAVE_ARCH_TRACEHOOK >> select HAVE_VIRT_CPU_ACCOUNTING >> + select HUGETLB_PAGE_SIZE_VARIABLE > > doesn't this need a 'if HUGETLB_PAGE' While making HUGETLB_PAGE_SIZE_VARIABLE a generic option, also made it dependent on HUGETLB_PAGE. Should not that gate HUGETLB_PAGE_SIZE_VARIABLE when HUGETLB_PAGE is not available irrespective of the select statement on the platforms ? > > or did you verify that HUGETLB_PAGE_SIZE_VARIABLE checks are always > nested inside of HUGETLB_PAGE ones? >
