On Thu, Feb 25, 2021 at 06:23:24PM +0100, David Hildenbrand wrote:
> On 25.02.21 17:31, George Kennedy wrote:
> > : rsdp_address=bfbfa014
> > [ 0.066612] ACPI: RSDP 0x00000000BFBFA014 000024 (v02 BOCHS )
> > [ 0.067759] ACPI: XSDT 0x00000000BFBF90E8 00004C (v01 BOCHS BXPCFACP
> > 00000001 01000013)
> > [ 0.069470] ACPI: FACP 0x00000000BFBF5000 000074 (v01 BOCHS BXPCFACP
> > 00000001 BXPC 00000001)
> > [ 0.071183] ACPI: DSDT 0x00000000BFBF6000 00238D (v01 BOCHS BXPCDSDT
> > 00000001 BXPC 00000001)
> > [ 0.072876] ACPI: FACS 0x00000000BFBFD000 000040
> > [ 0.073806] ACPI: APIC 0x00000000BFBF4000 000090 (v01 BOCHS BXPCAPIC
> > 00000001 BXPC 00000001)
> > [ 0.075501] ACPI: HPET 0x00000000BFBF3000 000038 (v01 BOCHS BXPCHPET
> > 00000001 BXPC 00000001)
> > [ 0.077194] ACPI: BGRT 0x00000000BE49B000 000038 (v01 INTEL EDK2
> > 00000002 01000013)
> > [ 0.078880] ACPI: iBFT 0x00000000BE453000 000800 (v01 BOCHS BXPCFACP
> > 00000000 00000000)
>
>
> Can you explore the relevant area using the page-flags tools (located in
> Linux src code located in tools/vm/page-flags.c)
>
>
> ./page-types -L -r -a 0xbe490,0xbe4a0
These are not iBFT and they are "ACPI data", so we should have them as
PG_Reserved set at init_unavailable_mem().
[ 0.000000] BIOS-e820: [mem 0x0000000000808000-0x000000000080ffff] usable
[ 0.000000] BIOS-e820: [mem 0x0000000000810000-0x00000000008fffff] ACPI NVS
[ 0.000000] BIOS-e820: [mem 0x0000000000900000-0x00000000be49afff] usable
^ iBFT@0xbe453 lives here ^
And it should be a normal page, as it's in "usable" memory and nothing
reserves it at boot, so no reason it won't be freed to buddy.
If iBFT was in the low memory (<1M) it would have been reserved by
reserve_ibft_region(), but with ACPI any block not marked by BIOS as "ACPI
something" is treated like a normal memory and there is nothing that
reserves it.
So we do need to memblock_reserve() iBFT region, but I still couldn't find
the right place to properly get its address without duplicating ACPI tables
parsing :(
[ 0.000000] BIOS-e820: [mem 0x00000000be49b000-0x00000000be49bfff] ACPI data
--
Sincerely yours,
Mike.
