From: Yang Li <abaci-bugfix@xxxxxxxxxxxxxxxxx> Subject: mm/swap_slots.c: remove redundant NULL check Fix below warnings reported by coccicheck: ./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed. Link: https://lkml.kernel.org/r/1611214229-11225-1-git-send-email-abaci-bugfix@xxxxxxxxxxxxxxxxx Signed-off-by: Yang Li <abaci-bugfix@xxxxxxxxxxxxxxxxx> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/swap_slots.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/swap_slots.c~mm-swap_slotsc-remove-redundant-null-check +++ a/mm/swap_slots.c @@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsign cache->slots_ret = NULL; } spin_unlock_irq(&cache->free_lock); - if (slots) - kvfree(slots); + kvfree(slots); } } _
